Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove spec requirement to contain all apis #1825

Merged
merged 6 commits into from
Dec 8, 2024

Conversation

omerlavanet
Copy link
Collaborator

@omerlavanet omerlavanet commented Dec 8, 2024

Description

  • adds a change in the functionality of specification API definitions, now APIs are allowed by default and need to be specifically blocked instead of only passing defined APIs, this allows easier integration of new chains and services
  • solves a race in the consumer (double read locks)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link

github-actions bot commented Dec 8, 2024

Test Results

2 347 tests  ±0   2 347 ✅ ±0   27m 18s ⏱️ ±0s
  122 suites ±0       0 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit 93dc8f0. ± Comparison against base commit ce4332c.

♻️ This comment has been updated with latest results.

ranlavanet
ranlavanet previously approved these changes Dec 8, 2024
@omerlavanet omerlavanet merged commit 6a7cf7b into main Dec 8, 2024
29 checks passed
@omerlavanet omerlavanet deleted the PRT-allow-missing-apis-in-spec branch December 8, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants